mirza
Posts: 9
Joined: Wed Jan 13, 2016 3:11 am

No error checking for valid version number when building from console

We cannot enter alphabets and only three level versions (as per microsoft msi specifications). Fair enough. But let's see we have following in .aip file.

<ROW Property="ProductVersion" Value="1.0.0-beta5" Type="32"/>
(we were getting product version from somewhere that is directly written into .aip file)

Now if we build the msi from .aip file from console or load the .aip file into GUI and build it without going to 'Product details' then we do not see any warning/error and .msi is built (with 1.0.0-beta5 is converted into 1.0.5). Only came to know this when tried to install version 1.0.1 and got error that a newer version is already installed.

Error checking for a valid product version is only done if we enter invalid product version in GUI. Ideally, it should also be done:

- As soon as .aip file is loaded into GUI
- When building the .aip file from console

Just consider that without this error checking verison 1.0.0-beta5 resulted into 1.0.5 and resulted the failure of all builds from version 1.0.1 to (actual) version 1.0.5. If a product version is invalid then we should not build the msi in any case.
Dan
Posts: 4530
Joined: Wed Apr 24, 2013 3:51 pm

Re: No error checking for valid version number when building from console

Hello,

Indeed, this seems to be an Advanced Installer limitation. A fix will be available in a future version of Advanced Installer, thank you for bringing it to our attention.

If there is anything else I can help you with, please let me know.

Best regards,
Dan
Dan Ghiorghita - Advanced Installer Team
Follow us: Twitter - Facebook - YouTube
Teodor
Posts: 73
Joined: Thu Jul 25, 2013 9:56 am

Re: No error checking for valid version number when building from console

Hi
mirza wrote: <ROW Property="ProductVersion" Value="1.0.0-beta5" Type="32"/>
(we were getting product version from somewhere that is directly written into .aip file)
If you enable Package Validation an invalid ProductVersion will be catched by ICE24:

Code: Select all

ERROR: ICE24. ProductVersion: '1.0.0-beta5' is an invalid version string.
Best regards
Teodor Micu - Advanced Installer Team
Follow us: Twitter - Facebook - YouTube
Dan
Posts: 4530
Joined: Wed Apr 24, 2013 3:51 pm

Re: No error checking for valid version number when building from console

Hello,

This was fixed in version 13.0 of Advanced Installer released on June 2nd, 2016.

Best regards,
Dan
Dan Ghiorghita - Advanced Installer Team
Follow us: Twitter - Facebook - YouTube
Dan
Posts: 4530
Joined: Wed Apr 24, 2013 3:51 pm

Re: No error checking for valid version number when building from console

You're welcome,

Should there be any difficulty you encounter implementing something, please do not hesitate to contact me and I will gladly assist.

Best regards,
Dan
Dan Ghiorghita - Advanced Installer Team
Follow us: Twitter - Facebook - YouTube

Return to “Common Problems”